PLANET-7647 Enforce consistency on default favicon #2507
Conversation
/unhold db2c7bb6-ff3e-4724-bce8-a489944395ff
/unhold dd69ef98-2642-443c-8125-ee64fb0a81a9
We remove the option to customize it in the site identity settings, and we need to run a migration to remove existing values
mleray
force-pushed
the
default-favicon
branch
from
98390d7 to
0e29a20
Compare
/unhold e137cd9c-7d5a-457a-94bf-e3ae73c7fe66
/unhold 4fd16a74-3aac-4022-b8b9-f491e69bbdb9
/unhold 987691d2-91db-4c08-a6e0-2aca9c68f5c1
Test instance is ready 🚀🌑 tavros | admin | blocks report | CircleCI | composer-local.json ⌚ 2025.01.21 11:26:41 |
mleray
requested review from
comzeradd,
a team and
Osong-Michael
and removed request for
a team
There was a problem hiding this comment.
Hey @mleray after the migration, we loose the favicon for the page when on the admin dashboard and not the site itself, is this the expected behaviour?
Test Instance
Local Instance
PS: Does not seem like a big deal since only editors use this.
@Osong-Michael I do not see this on the instance 🤔 The icon is updated in the admin interface too 
Edit: I do see the issue on local, but only in certain admin pages, not all of them... weird! |
|
I would like @comzeradd to have a look since we have issues on local... on the instance everything seems to be fine though |
Not sure where the admin panel gets its favicon. I don't see anything relevant on the html markup. On admin panel, I don't see the icon at all indeed when at local. On the test instance, I see the right one while in frontend. But I still see the wrong one (with the colored background) in the admin panel even on private/incognito mode. |
Ref: https://jira.greenpeace.org/browse/PLANET-7647 --- Follow up from #2507, there is one more additional option besides the one we disabled.
Ref: https://jira.greenpeace.org/browse/PLANET-7647 --- Follow up from #2507, there is one more additional option besides the one we disabled.
Ref: https://jira.greenpeace.org/browse/PLANET-7647 --- Follow up from #2507, there is one more additional option besides the one we disabled.
Description
See PLANET-7647
We remove the option to customize it in the site identity settings, and we need to run a migration to remove existing values
Testing
1. Setting removal
If you go to
Appearance > Customize > Site Identityyou should no longer be able to change the site icon.Before the removal you would see this:
2. Migration script
You can run it on local with
npx wp-env run cli wp p4-run-activatorBefore the migration, we had a custom site icon:
After the migration, you should now see the default site icon: